feat(firebase): deploy to Cloud Functions for Firebase#53
Merged
MichaelDeBoey merged 1 commit intoremix-run:mainfrom Jan 25, 2023
Merged
feat(firebase): deploy to Cloud Functions for Firebase#53MichaelDeBoey merged 1 commit intoremix-run:mainfrom
MichaelDeBoey merged 1 commit intoremix-run:mainfrom
Conversation
2 tasks
MichaelDeBoey
changed the title
github-actions
bot
added
the
needs-response
Contributor
Author
|
@machour @mcansh @MichaelDeBoey Similar to my comment on #52 (comment) Please let me know if I should keep rebasing this or abandon it |
github-actions
bot
removed
the
needs-response
Member
|
@penx Please rebase this branch onto latest |
Ported from remix-run/remix#3398 fix yarn lock on main
penx
force-pushed
the
firebase-functions
branch
from
dec444c to
56f86ed
Compare
mcansh
approved these changes
Jan 25, 2023
Contributor
Author
|
@MichaelDeBoey thanks for merging, I was trying to figure out the yarn lock, which will now be out of date in main. Hopefully will get there shortly! |
Contributor
Author
|
I've resolved my issue with yarn, and the root lock file seems to be fine as it doesn't contain dependencies for each example |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening #5, remix-run/remix#3398 against remix-run/examples
Deploy to firebase functions and hosting
Closes: Discussion at remix-run/remix#1811 (comment)
Testing Strategy: